- From: Lennart Grahl via GitHub <sysbot+gh@w3.org>
- Date: Sun, 24 Sep 2017 00:46:05 +0000
- To: public-ortc@w3.org
lgrahl has just submitted a new pull request for https://github.com/w3c/ortc: == Add RTCSctpTransport.setTransport == These changes add a `setTransport` to the SCTP transport to allow seemless changing of the underlying DTLS transport. It also adds a missing state check for the DTLS transport instance on construction. Some questions are left: ##### 1. DTLS transport state on construction/`setTransport` When constructing an instance that requires a DTLS transport, the description is: > If an attempt is made to construct an RTCRtpSender object with transport.state or rtcpTransport.state closed Shouldn't the `failed` state be covered by the description, too? (The same would need to be applied to the description of `setTransport`.) ##### 2. `state` vs. `ObjectNameState` I've seen that in the `RTCSctpTransport` to reference the current active state, `RTCSctpTransportState` is being used instead of just `state` (to refer the local attribute) as in the `RTCQuicTransport.start` method. Should we unify this for consistency (and by which method)? ##### 3. DTLS transport component check Do we need a `dtlsTransport.transport.component` check on construction of the SCTP transport (and on calling `setTransport`)? If the `component` is not `rtp`, this should be an error, right? See https://github.com/w3c/ortc/pull/775
Received on Sunday, 24 September 2017 00:45:56 UTC