W3C home > Mailing lists > Public > public-ortc@w3.org > June 2017

[ortc] dtmfsender 1.0 compability

From: Philipp Hancke via GitHub <sysbot+gh@w3.org>
Date: Wed, 21 Jun 2017 17:26:24 +0000
To: public-ortc@w3.org
Message-ID: <issues.opened-237608443-1498065982-sysbot+gh@w3.org>
fippo has just created a new issue for https://github.com/w3c/ortc:

== dtmfsender 1.0 compability ==
http://w3c.github.io/webrtc-pc/#peer-to-peer-dtmf defines the dtmf sender a bit different than we do here.

It turned out to be fairly trivial to shim (in Edge):
```
Object.defineProperty(window.RTCRtpSender.prototype, 'dtmf', {
    get: function() {
        if (this._dtmf === undefined) {
            if (this.track.kind === 'audio') {
                this._dtmf = new window.RTCDtmfSender(this);
            } else if (this.track.kind === 'video') {
                this._dtmf = null;
            }
        }
        return this._dtmf;
    }
});
```
Its a "how do I shim 1.0 ontop of ORTC issue", shall I make a PR for http://draft.ortc.org/#webrtc-compat* ?

Please view or discuss this issue at https://github.com/w3c/ortc/issues/714 using your GitHub account
Received on Wednesday, 21 June 2017 17:26:30 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 21 June 2017 17:26:30 UTC