- From: Bernard Aboba <Bernard.Aboba@microsoft.com>
- Date: Fri, 7 Mar 2014 13:39:18 +0000
- To: "public-orca@w3.org" <public-orca@w3.org>
Some NITs in the editor's draft:
http://ortc.org/wp-content/uploads/2014/02/ortc.html
(1) No definition of RTCIceParameters and RTCDtlsParameters
(2)
example 3
var ice = new RTCIceTransport(iceOptions); // where is the role parameter?
(3)
RTCIceCandidate example is out of date with connectionAddress and connectionPort
{
foundation: "abcd1234",
priority: 1694498815,
connectionAddress: "192.0.2.33",
connectionPort: 10000,
type: "host"
};
(4)
// readonly attributes for track and transport below ?
[Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpSender {
attribute MediaStreamTrack track;
attribute RTCDtlsTransport transport;
[Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpReceiver {
attribute MediaStreamTrack? track;
attribute RTCDtlsTransport transport;
(5)
// typo "sending" should be "receiving" below
An RTCRtpReceiver instance is associated to a sending MediaStreamTrack
(6)
In example 8,
// The responder answers with parameters it wants to send with
// and the capabilities it has for receiving.
audioSendParams = RTCRtpSender.filterParameters(
sendAudioParams, answer.rtpCaps);
videoSendParams = RTCRtpSender.filterParameters(
sendVideoParams, answer.rtpCaps
var audioRecvParams = RTCRtpSender.filterParameters(
answer.audio);
var videoRecvParams = RTCRtpSender.filterParameters(
answer.video);
should be ?
// The responder answers with parameters it wants to send with
// and the capabilities it has for receiving.
audioSendParams = RTCRtpSender.filterParameters(
sendAudioParams, answer.rtpCaps);
videoSendParams = RTCRtpSender.filterParameters(
sendVideoParams, answer.rtpCaps
var audioRecvParams = RTCRtpReceiver.filterParameters(
answer.audio);
var videoRecvParams = RTCRtpReceiver.filterParameters(
answer.video);
In example 9,
var audioSendParams = RTCRtpSender.createParameters(
audioTrack, remote.rtpCaps);
var videoSendParams = RTCRtpSender.createParameters(
videoTrack, remote.rtpCaps);
var audioRecvParams = RTCRtpSender.filterParameters(
remote.audio);
var videoRecvParams = RTCRtpSender.filterParameters(
remote.video);
should be ?
var audioSendParams = RTCRtpSender.createParameters(
audioTrack, remote.rtpCaps);
var videoSendParams = RTCRtpSender.createParameters(
videoTrack, remote.rtpCaps);
var audioRecvParams = RTCRtpReceiver.filterParameters(
remote.audio);
var videoRecvParams = RTCRtpReceiver.filterParameters(
remote.video);
(7)
In [Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpReceiver {
track should not be there for the receiver. Example 8 and example 9 do not have track in constructor:
...
var audioReceiver = new RTCRtpReceiver(transport);
var videoReceiver = new RTCRtpReceiver(transport);
...
var audioReceiver = new RTCRtpReceiver(transport);
var videoReceiver = new RTCRtpReceiver(transport);
...
Received on Friday, 7 March 2014 13:39:48 UTC