Re: Test Suite update

Thanks a lot, Leroy. This is very good timing also because the test suite
is linked from

http://www.w3.org/TR/2012/WD-its20-20120829/#major-changes

which will be published today. A few  more suggestions:

- there are several ID values that are not unique in the HTML document,
e.g.

translate-globalandlocal-star


I think you don't need IDs in the "td" elements like here, just at the "tr"
element


<tr id="translate-globalandlocal-star">
             <td colspan="1" align="left" valign="top" id=
"translate-globalandlocal-star">Global (with //*) and local rules</td>
             <td align="center" valign="top" id=
"translate-globalandlocal-star"><a href="
http://www.w3.org/International/multilingualweb/lt/drafts/its20/its20.html#translate-global
">translate-global</a></td>
             <td align="center" valign="top" id=
"translate-globalandlocal-star">XML</td>
             <td rowspan="1" align="center" valign="top" bgcolor="#FFFFFF"id
="table9">Translate5.xml</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star"><a href="view-source:
http://phaedrus.scss.tcd.ie/its2.0/inputdata/translate/xml/Translate5.xml"shape
="rect">Source</a></td>
             <td rowspan="1" align="center" valign="top" bgcolor="#FFFFFF"id
="translate-globalandlocal-star">Translate5-result.xml</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#33CC00" id="translate-globalandlocal-star"><a href=
"expected/translate/xml/Translate5-result.xml" shape="rect">Result</a></td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
             <td rowspan="1" align="center" valign="top" bgcolor="#FFFFFF"id
="translate-globalandlocal-star">&nbsp;</td>
             <td colspan="1" rowspan="1" align="center" valign="top" bgcolor
="#FFFFFF" id="translate-globalandlocal-star">&nbsp;</td>
           </tr>

Could you make sure that each table row, i.e "tr" element, has a unique id
value?

Also, can you make sure that the test suite page
http://phaedrus.scss.tcd.ie/its2.0/its-testsuite.html
is valid XHTML? I want to run the tests automatically by loading the page
in an XSLT processor, processing the table and comparing the results to the
expected results. For that I need a valid test suite page.

Thanks,

Felix

2012/8/28 Leroy Finn <finnle@tcd.ie>

> Hey Felix,
>
> I corrected the points you made on your email earlier today. I will add in
> the additional Locale Filter test tomorrow. Thanks for reviewing the draft
> of the test suite again.
>
>
>> Locale filter: there should be a test for the HTML5 its-locale-filter
>> attribute.
>>
>
> Thanks,
> Leroy
>
> On 28 August 2012 12:43, Leroy Finn <finnle@tcd.ie> wrote:
>
>> Hey Yves and Felix,
>>
>> Thanks for the feedback.
>>
>>  Hi Leroy, all,
>>>
>>> thanks again for the updates. Here are some errors I found. I only
>>> checked the HTML5 examples.
>>>
>>>
>>> http://phaedrus.scss.tcd.ie/its2.0/inputdata/translate/html/Translate4Html.xml
>>> this doesn't need a global rule - "translate" is a native HTML5
>>> attribute.
>>>
>>>
>> Yeah i noticed that i made that mistakes in some parts with putting in a
>> rule files for local tests. This is a mistake by me I have re-run these
>> file through the test suite the way they are meant to be.  I will re-post
>> the correct ones in a few minutes.
>>
>>
>>>
>>> http://phaedrus.scss.tcd.ie/its2.0/inputdata/translate/html/Translate6Rules.xml
>>> the above file and I think several other HTML5 examples miss the HTML
>>> namespace declaration. You need to add this (xmlns:h="...") and change the
>>> XPath expressions, e.g. "//p" to "//h:p".
>>>
>>>
>>> http://phaedrus.scss.tcd.ie/its2.0/inputdata/localizationNote/html/Loc7Html.xml
>>> Again you don't need a rules file. The its-* attributes are native ITS.
>>>
>>>
>>> http://phaedrus.scss.tcd.ie/its2.0/inputdata/elementsWithinText/html/Within2Html.xml
>>> Why does this have the namespace http://my.DocumentURI/?
>>>
>>>
>> This is a mistake on my behalf when converting from XML to HTML5.
>>
>>
>>> Locale filter: there should be a test for the HTML5 its-locale-filter
>>> attribute.
>>>
>>
>> I didn't notice this in the test suite when i was doing it before. I will
>> update the test suite and run this test now.
>>
>>
>>>
>>>
>> http://phaedrus.scss.tcd.ie/its2.0/inputdata/idvalue/xml/idvalue2xml.xml
>>> This is not needed - Id value is global only.
>>>
>>>
>>  Sorry my mistake i will remove this now from the test suite
>>
>> It probably makes sense to go through all HTML5 examples and check wether
>>> they use its-* (instead of its:*) and the HTML namespace.
>>>
>>
>> I think your right i will double checks these now and i will add in the
>> HTML namespace into the rule files.
>>
>> Thanks for the help and advice,
>> Leroy Finn
>>
>>
>>>
>>> 2012/8/24 Leroy Finn <finnle@tcd.ie>
>>>
>>>> Dear All,
>>>>
>>>> I will be have created the test files for the following data categories
>>>> and should be publishing them on the test suite web page (located here
>>>> http://phaedrus.scss.tcd.ie/its2.0/its-testsuite.html) by Monday
>>>> evening. The data categorises that will be added by Monday evening (27th
>>>> August) are as follows:
>>>>
>>>>    - Disambiguation(not finalised in draft yet according to yesterdays
>>>>    call)
>>>>    - Target Pointer
>>>>    - Id value
>>>>    - Preserve space
>>>>
>>>>
>>>> Next week I will be working on the following data categories:
>>>>
>>>>    - Localization Quality Issue
>>>>    - Localization Quality Précis
>>>>
>>>> Again any helpful pointers or mistakes found test suite page would be
>>>> much appreciated. Any questions on the test suite or any problems just ask
>>>> me.
>>>>
>>>> Thanks,
>>>>
>>>> Leroy Finn
>>>>
>>>
>>>
>>>
>>> --
>>> Felix Sasaki
>>> DFKI / W3C Fellow
>>>
>>>
>>
>


-- 
Felix Sasaki
DFKI / W3C Fellow