- From: Francois Daoust <fd@w3.org>
- Date: Mon, 01 Jun 2009 14:33:38 +0200
- To: Yeliz Yesilada <yesilady@cs.man.ac.uk>
- CC: public-mobileok-checker <public-mobileok-checker@w3.org>
Yes. That doesn't make any sense to keep a method that won't ever be implemented in practice. The fileToURI method can be suppressed as well. Francois. Yeliz Yesilada wrote: > If you have no objection, can we also delete this private method from > the Tester class? > > private Tester(final File file) { > this(fileToURI(file)); > } > > Since it is not used and cannot be, I think it is confusing for people > who would like to use this library. > > Regards, > Yeliz. > On 29 May 2009, at 09:46, Yeliz Yesilada wrote: > >> As part of handling "file" scheme extension, I had to also make two >> minor changes to the mobileOK source code. This definitely doesn't >> effect the reference implementation at all. >> >> Tester class >> ========= >> In the main method of this class we added another command line option >> called "-c" that allows people to specify a configuration file (If >> other people also would like to extend this library). For example, >> validating pages with "file" scheme, a new configuration class has to >> be provided. This was important to add an extension without affecting >> the reference implementation. If a configuration is not specified, >> default mobileOK configuration is used. >> >> PreProcessorResults >> ================ >> In this class, a new getter method is added to be able to get hold of >> the "Resources" retrieved by the validator. >> >> These changes have been committed back to the CVS repository. >> >> Regards, >> Yeliz >> -------------------------------------------------------- >> School of Computer Science >> The University of Manchester >> Manchester >> M13 9PL >> >> URL: http://www.cs.man.ac.uk/~yesilady/ >> Tel: +44 (0) 161 275 6239 >> Fax: +44 (0) 845 139 5599 >> -------------------------------------------------------- >> >> >> >> > > >
Received on Monday, 1 June 2009 12:34:13 UTC