Re: Test case review TC0027 - TC0065

Hi Silvia,

On 6/07/2011 14:34, Silvia Pfeiffer wrote:
> TC0034 uses an escaped equals sign (%3D). This percent-encoding does
> not resolve since the equals sign is a separator, thus the fragment
> string is not interpreted as a media fragment. I think the effect of
> the test is correct, but the explanation why it fails in the comment
> is incorrect.
> I suggest replacing
> "UA knows that this is an invalid media fragment" ->  "UA does not
> identify this as a media fragment"...
Done.

> TC0045 to TC0047 all represent valid spatial fragments. TC0047 states
> a conversion from percent to pixels, but I was not able to find a
> statement of the resolution of the full video.
> I suggest adding "The video's full resolution is 1280x720px".
The resolution is described for the media of this test case (i.e., 
http://www.w3.org/2008/WebVideo/Fragments/TC/media#spatial_30fps_webm). 
However, I agree that this should also be visible in the HTML 
representation. Therefore, I added your suggested sentence.

> TC0048 uses a width and height of 0 for the cropped area. I don't
> think that's invalid according to our production rules. Even though
> our informative section 6.1.2 states that the width and height need to
> be larger than 0 to be valid, that's not what the production rules
> state.
> I suggest replacing
> "Invalid spatial coordinates." ->  "Invalid semantics: width and height
> of cropped region must be larger than 0. The media fragment is
> ignored."
Done.

> Similarly TC0050 uses a width and height of more than 100% for the
> cropped area. I don't think that's invalid according to our production
> rules. Even though our informative section 6.1.2 states that a+c<=
> 100 and b+d<= 100 to be valid, that's not what the production rules
> state.
> I suggest replacing
> "Invalid spatial coordinates." ->  "Invalid semantics: width and height
> of cropped region must be larger than 0. The media fragment is
> ignored."
Done. I suppose you meant something like "Invalid semantics: width and 
height percentages of a cropped region must be smaller or equal to 100. 
The media fragment is ignored and the full media resource is requested."?

> TC0057 should state that the full media resource is downloaded.
Done.

> TC0058 is not a media fragment.
> I suggest replacing
> "UA knows that this is an invalid media fragment" ->  "UA does not
> identify this as a media fragment"...
Done.

Thx for the review!

Best regards,

Davy

-- 
Davy Van Deursen

Ghent University - IBBT
Department of Electronics and Information Systems - Multimedia Lab
URL: http://multimedialab.elis.ugent.be/dvdeurse

Received on Thursday, 7 July 2011 08:05:03 UTC