W3C home > Mailing lists > Public > public-media-capture@w3.org > October 2016

[mediacapture-image] All examples are invalid

From: François Beaufort via GitHub <sysbot+gh@w3.org>
Date: Wed, 12 Oct 2016 14:13:24 +0000
To: public-media-capture@w3.org
Message-ID: <issues.opened-182536621-1476281603-sysbot+gh@w3.org>
beaufortfrancois has just created a new issue for 
https://github.com/w3c/mediacapture-image:

== All examples are invalid ==
### 
https://w3c.github.io/mediacapture-image/#grabbing-a-frame-for-post-processing

- extra parenthesis
- `if (captureDevice) {` is not necessary
- `imgData` is not defined
- `processFrame` can't use `imgData.data` as there as no `data` in 
`imageBitmap`.

### 
https://w3c.github.io/mediacapture-image/#taking-a-picture-with-red-eye-reduction-supported-and-used
 

- `if (captureDevice) {` is not necessary
- `captureDevice.photoCapabilities.redEyeReduction` is invalid
- `redEyeReductionSetting` is an invalid option. it should be 
`redEyeReduction`
- `.then(captureDevice.takePhoto()` is missing a parenthesis
- `img.src = URL.createObjectURL(e.data);` should be `img.src = 
URL.createObjectURL(blob);`

### 
https://w3c.github.io/mediacapture-image/#repeated-grabbing-of-a-frame

- `var frameVar;` should be defined outside of this function and maybe
 even renamed 
- `if (captureDevice) {` is not necessary
- `then(processFrame())` should be `then(processFrame)`
- `function processFrame(e) {` should be `function 
processFrame(imgData) {`

Please view or discuss this issue at 
https://github.com/w3c/mediacapture-image/issues/99 using your GitHub 
account
Received on Wednesday, 12 October 2016 14:13:31 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:26:37 UTC