- From: Adam Bergkvist via GitHub <sysbot+gh@w3.org>
- Date: Tue, 24 Oct 2017 05:05:17 +0000
- To: public-media-capture-logs@w3.org
Very nice PR! I made a little node script that extracts all the example snippets from the spec and runs eslint on them. Using Google style as a base, this PR only has a few minor style issues (if we disregard from the double quotes :)). In most cases I like spaces between curly braces and the content and https://github.com/w3c/webrtc-pc/pull/1618 still has a *lot* of them. Whichever way we go I think we should be consistent between mediacapture-main and webrtc-pc. -- GitHub Notification of comment by adam-be Please view or discuss this issue at https://github.com/w3c/mediacapture-main/pull/486#issuecomment-338874932 using your GitHub account
Received on Tuesday, 24 October 2017 05:05:19 UTC