- From: jan-ivar via GitHub <sysbot+gh@w3.org>
- Date: Fri, 23 Jun 2017 18:05:03 +0000
- To: public-media-capture-logs@w3.org
@yellowdoge I think you meant @dsanders11. 😏
Reading through this, I don't have a strong opinion on rounding errors, but I would like to point out the several other ways that @dsanders11's [example](https://github.com/w3c/mediacapture-image/pull/182#issuecomment-308837309) won't work:
1. Busy-spinning on `getSettings()` waiting for it to change will always hang, because implementations generally queue tasks to update JS state. Use `await`.
2. `track.applyConstraints({pan})` is the same as `track.applyConstraints({pan: {ideal: pan}})` and does not guarantee a value. Your page may be one of several tabs accessing the singular device simultaneously, and the browser chooses the final value. Use `track.applyConstraints({pan: {exact: pan}})` to force a value or fail.
3. Does `applyConstraints()` wait for the motor? I dunno. I've filed https://github.com/w3c/mediacapture-main/issues/470.
--
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/mediacapture-image/pull/182#issuecomment-310734384 using your GitHub account
Received on Friday, 23 June 2017 18:05:09 UTC