W3C home > Mailing lists > Public > public-media-capture-logs@w3.org > April 2017

Re: [mediacapture-image] Rename takePhoto method

From: Miguel Casas-Sanchez via GitHub <sysbot+gh@w3.org>
Date: Thu, 06 Apr 2017 16:59:19 +0000
To: public-media-capture-logs@w3.org
Message-ID: <issue_comment.created-292238032-1491497957-sysbot+gh@w3.org>
Updated table (change in bold)

dev  | `takePhoto()` | `capture()` | `captureImage()` | `takePicture()` |
-----|:--:|:--:|:--:|:--:|
@mounirlamouri  | nay | aye | ? | ? |
@beaufortfrancois | nay | aye | aye | **aye** |
@shwetank  | ? | **aye** | aye | ? |
@dandv | aye |  | | aye |
@miguelao | aye |  | | |


Shipping wise: no sweat, it's literally a one line change in [`ImageCapture.idl`](https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl?q=imagecapture.idl&sq=package:chromium&dr), where it reads:
` [CallWith=ScriptState] Promise<Blob> takePhoto();`
it should read:
` [CallWith=ScriptState, ImplementedAs=takePhoto] Promise<Blob> capture();`


-- 
GitHub Notification of comment by miguelao
Please view or discuss this issue at https://github.com/w3c/mediacapture-image/issues/88#issuecomment-292238032 using your GitHub account
Received on Thursday, 6 April 2017 16:59:26 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:27:32 UTC