W3C home > Mailing lists > Public > public-media-capture-logs@w3.org > December 2016

[mediacapture-depth] Pull Request: Replace near/far by depthNear/depthFar. Fix compilation on Windows.

From: Aleksandar Stojiljkovic via GitHub <sysbot+gh@w3.org>
Date: Thu, 29 Dec 2016 11:35:27 +0000
To: public-media-capture-logs@w3.org
Message-ID: <pull_request.opened-99645958-1483011325-sysbot+gh@w3.org>
astojilj has just submitted a new pull request for 
https://github.com/w3c/mediacapture-depth:

== Replace near/far by depthNear/depthFar. Fix compilation on Windows.
 ==
Reason:
Generated C++ code from IDL cannot compile on Windows since near
and far are reserved keywords MS compiler.

It might be possible to undef it in C++ headers but this seems more
appropriate since:

MediaTrackSettings and other dictionaries are generic, meaning that
they apply to all stream tracks and it is good to explicitelly mark
that this applies only to depth. On the other side focalLength,
principal point and other intrinsics that we plan to add apply to
all cameras so there is no need to prefix them with depth.

This way, it is also in sync with depthNear and depthFar in WebVR
API's depthNear/depthFar[1].

[1]
https://w3c.github.io/webvr/#dom-vrdisplay-depthnear

See https://github.com/w3c/mediacapture-depth/pull/148
Received on Thursday, 29 December 2016 11:35:33 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:27:31 UTC