W3C home > Mailing lists > Public > public-media-capture-logs@w3.org > December 2016

Re: [mediacapture-image] Use the constrainable pattern instead of creating a subtly different function set

From: jan-ivar via GitHub <sysbot+gh@w3.org>
Date: Mon, 19 Dec 2016 23:44:51 +0000
To: public-media-capture-logs@w3.org
Message-ID: <issue_comment.created-268111890-1482191089-sysbot+gh@w3.org>
I agree with @alvestrand that two nearly identical patterns is a bad 
thing. But two constrainable objects isn't great either. Let's reuse 
the one we have. Move `zoom`.

I agree with @gmandyam there's no contention for settings effective 
only during `takePhoto`(where overlap causes `UnknownError`), making 
the constrainable pattern overkill for the remaining settings.

**Solution:** With `zoom` out of the picture (no pun intended), make 
`takePhoto` take an options object, and remove `setOptions`, then the 
patterns seem sufficiently different.

This streamlines the API by handling the two fundamentally different 
kinds of settings optimally.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at 
https://github.com/w3c/mediacapture-image/issues/124#issuecomment-268111890
 using your GitHub account
Received on Monday, 19 December 2016 23:44:57 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:27:31 UTC