W3C home > Mailing lists > Public > public-media-capture-logs@w3.org > November 2015

[mediacapture-main] Pull Request: Fix applyConstraints steps to avoid unused var and bail on reject.

From: jan-ivar via GitHub <sysbot+gh@w3.org>
Date: Sat, 14 Nov 2015 04:06:34 +0000
To: public-media-capture-logs@w3.org
Message-ID: <pull_request.opened-50715785-1447473993-sysbot+gh@w3.org>
jan-ivar has just submitted a new pull request for 
https://github.com/w3c/mediacapture-main:

== Fix applyConstraints steps to avoid unused var and bail on reject.
  ==
The steps never bail after rejecting the promise, causing 
*newConstraints* to be applied regardless of failure. I also removed 
the use of the undefined *existingConstraints* variable.

See https://github.com/w3c/mediacapture-main/pull/272
Received on Saturday, 14 November 2015 04:06:37 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:27:28 UTC