- From: Gregg Kellogg <gregg@greggkellogg.com>
- Date: Wed, 28 Aug 2013 14:25:15 -0700
- To: Markus Lanthaler <markus.lanthaler@gmx.net>
- Cc: "'Linked JSON'" <public-linked-json@w3.org>
On Aug 28, 2013, at 1:11 PM, Gregg Kellogg <gregg@greggkellogg.com> wrote: > On Aug 28, 2013, at 11:54 AM, Markus Lanthaler <markus.lanthaler@gmx.net> wrote: > >> On Wednesday, August 28, 2013 12:56 AM, Gregg Kellogg wrote: >>> I believe I've created all of the error test cases that are called >>> for in the API spec, except those that are defined for the API itself >>> (e.g., "loading document failed"). >> >> Awesome! Thanks a lot for taking the lead on this Gregg. >> >> >>> Most of these tests are for Expand, but there is one for Compact and >>> one for Flatten, so the @type of the test entries reflects this. >> >> Couldn't we simplify the test runner by turning all of them into Flatten >> tests? Flatten calls expansion and compaction internally. > > At this point, that would hardly be simplifying anything, as the work has been done. Easiest to test the specific APIs which will bring about the behavior, which is typically Expand. It should be easy enough to look in the @type for Expand, Flatten, or Compact to trigger the appropriate behavior. Actually, as it doesn't involve any filename changes, it's a pretty easy search and replace. I've made the change, and I'll update the test documentation; all tests in the error-manifest can be run using the Flatten algorithm. Gregg > Gregg > >> -- >> Markus Lanthaler >> @markuslanthaler >> >> >
Received on Wednesday, 28 August 2013 21:25:45 UTC