Re: Contributing to the test suite

Ruben, my practice has been to add tests for every change to the API document, so every new feature should have tests. It might be worth looking at closed PRs to find the tests that accompany them. That said, there certainly may be aspects of the feature which would use better tests. 

Gregg Kellogg
Sent from my iPhone

> On Apr 1, 2019, at 3:41 PM, Ruben Taelman <ruben.taelman@ugent.be> wrote:
> 
> Dear all,
> 
> I recently started implementing some of the new JSON-LD 1.1 features.
> However, I noticed that for most of these new features,
> no tests have been created yet in the test suite.
> 
> As I am writing my own unit tests in any case,
> it would not be a lot of overhead for me to add these to the test suite as well.
> Concretely, I could start by contributing ‘toRdf’ tests.
> 
> Before I start sending in PRs for this,
> I first want to ask whether or not tests should already be created at this point,
> and if there are things I should keep in mind while defining these tests
> (other than mentioned in the README [1]).
> 
> [1] https://w3c.github.io/json-ld-api/tests/
> 
> Kind regards,
> Ruben Taelman