Re: [clreq] feat: support dark mode (#612)

Thanks for updating the PR! I made some comments.

IMHO we can consider using CSS custom properties (like https://github.com/w3c/bp-i18n-specdev/pull/130 ), so that when updating the colour, it is easier to remember that we also have a dark theme that needs to be updated.

-- 
GitHub Notification of comment by xfq
Please view or discuss this issue at https://github.com/w3c/clreq/pull/612#issuecomment-2017336223 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 25 March 2024 06:50:29 UTC