- From: Karol Szczepański via GitHub <sysbot+gh@w3.org>
- Date: Thu, 02 Nov 2017 21:42:11 +0000
- To: public-hydra-logs@w3.org
<img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/> --- Review status: all files reviewed at latest revision, 2 unresolved discussions. --- *[drafts/use-cases/5.1.creating-event-with-put.md, line 34 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxZXSL5Owpv1cqTG5AR:-KxyeNk5xMO0-5eOZcc0:b-2sc3bk) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-event-with-put.md#L34)):* <details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote> LGTM </blockquote></details> Looks nice - do you want to extend those operation arrays with fluent-like API? There may be already something that we could use. --- *[drafts/use-cases/5.1.creating-event-with-put.md, line 72 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxchCDgCDQQ4nzkMnf4:-Kxyf1s5Bdutrv68594j:bwh1xmr) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-event-with-put.md#L72)):* <details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote> Agreed, it doesn't have to necessarily be a property from the payload. We need to define how this is supposed to work better at some point. I think this is currently one of the weakest aspects of Hydra. </blockquote></details> I believe the spec doesn't say anything on where the value of the property being mapped should come from. In some cases indeed it can be taken from the payload, but for some other i.e. from user input or auto-generated. I think this is a topic for another story. --- *Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/143#-:-KxyflT_zvTSez0DXTg0:bnfp4nl)* <!-- Sent from Reviewable.io --> -- GitHub Notification of comment by alien-mcl Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/143#issuecomment-341566938 using your GitHub account
Received on Thursday, 2 November 2017 21:42:13 UTC