- From: elf Pavlik via GitHub <sysbot+gh@w3.org>
- Date: Mon, 14 Aug 2017 13:35:59 +0000
- To: public-hydra-logs@w3.org
Review status: 2 of 7 files reviewed at latest revision, 4 unresolved discussions. --- *[drafts/use-cases/1.1.security-considerations.md, line 18 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUSFWcxbytETQ1yIEc:-KrVnkbjIm6WCU_qLzpF:bk6alry) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/1.1.security-considerations.md#L18)):* Could you please explain what you mean by: > But, I don't like how it loses the API-scecificness. To my understanding clients need a way to discover from the `hydra:EntryPoint` collection with members of type `schema:Event`. But this general conversation already happens in https://github.com/HydraCG/Specifications/issues/126 --- *[drafts/use-cases/5.creating-new-event.md, line 29 at r1](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrT4ZeUK43qWAnpOI76:-KrVmtzhntSVrK3lTxKk:bkae26r) ([raw file](https://github.com/hydracg/specifications/blob/7a85c04e5cbfa0958d3ffd64bb3fafbb423a1361/drafts/use-cases/5.creating-new-event.md#L29)):* <details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote> I don't understand. You completely replaced the following of `#events` link with the `getCollection` call? In this case how does the client know which URL to retrieve? </blockquote></details> `@id` of the matching `hydra:Collection` I haven't thought of a case where multiple ones match but AFAIK `hydra:Link` also doesn't have restriction to reference only one resource --- *[drafts/use-cases/7.searching-events.md, line 94 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUTEC8cxSsvr6wpaDZ:-KrVlhLXqKM0BVudpPqz:b-lxdirj) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/7.searching-events.md#L94)):* <details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote> Is this really a collection or a partial view? </blockquote></details> Good question, I hope Markus and Karol can chime in on that. I could always remove this change from this PR since it doesn't really belong in it. --- *[drafts/use-cases/8.filtering-events.md, line 97 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUTKKWRIulTHryZKEN:-KrVx6rbzWUu1Q1M2vt0:b-3k7s37) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/8.filtering-events.md#L97)):* <details><summary><i>Previously, tpluscode (Tomasz Pluskiewicz) wrote…</i></summary><blockquote> Ditto, Is this really a collection or a partial view? </blockquote></details> I could also undo this change and leave it for another PR --- *Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/132)* <!-- Sent from Reviewable.io --> -- GitHub Notification of comment by elf-pavlik Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/132#issuecomment-322191605 using your GitHub account
Received on Monday, 14 August 2017 13:36:00 UTC