- From: Tomasz Pluskiewicz via GitHub <sysbot+gh@w3.org>
- Date: Mon, 14 Aug 2017 06:41:22 +0000
- To: public-hydra-logs@w3.org
Reviewed 2 of 7 files at r1. Review status: 2 of 7 files reviewed at latest revision, 4 unresolved discussions. --- *[drafts/use-cases/1.1.security-considerations.md, line 18 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUSFWcxbytETQ1yIEc:-KrUSFWcxbytETQ1yIEd:b56qa6n) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/1.1.security-considerations.md#L18)):* > ```Markdown > "@id": "/api", > "@type": "hydra:EntryPoint", > "collection": { > ``` Are you sure we should be changing this to `hydra:collection`? I guess this change answers my previous questions. But, I don't like how it loses the API-scecificness. --- *[drafts/use-cases/7.searching-events.md, line 94 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUTEC8cxSsvr6wpaDZ:-KrUTEC8cxSsvr6wpaD_:b-hg6vaa) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/7.searching-events.md#L94)):* > ```Markdown > "@context": "/api/context.jsonld", > "@id": "/api/events?search=some text", > "@type": "hydra:Collection", > ``` Is this really a collection or a partial view? --- *[drafts/use-cases/8.filtering-events.md, line 97 at r2](https://reviewable.io:443/reviews/hydracg/specifications/132#-KrUTKKWRIulTHryZKEN:-KrUTKKWRIulTHryZKEO:b3hyiz6) ([raw file](https://github.com/hydracg/specifications/blob/8c2db652e54f3e4ed52b855e05c73330d9d2d2ea/drafts/use-cases/8.filtering-events.md#L97)):* > ```Markdown > "@context": "/api/context.jsonld", > "@id": " /api/events?schema:eventName=.*test.*", > "@type": "hydra:Collection", > ``` Ditto, Is this really a collection or a partial view? --- *Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/132)* <!-- Sent from Reviewable.io --> -- GitHub Notification of comment by tpluscode Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/132#issuecomment-322111335 using your GitHub account
Received on Monday, 14 August 2017 06:41:22 UTC