RE: Fix Bug 17686 - Audio tests use video element

This diff looks just fine, feel free to update these approved tests

From: Zhang, Zhiqiang [mailto:zhiqiang.zhang@intel.com] 
Sent: Tuesday, July 17, 2012 6:20 PM
To: public-html-testsuite@w3.org
Subject: Fix Bug 17686 - Audio tests use video element

Below is the diff of the fix.


diff --git a/tests/approved/audio/event_canplay.html b/tests/approved/audio/event_canplay.html
--- a/tests/approved/audio/event_canplay.html
+++ b/tests/approved/audio/event_canplay..html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - canplay</title>
+  <title>audio events - canplay</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger canplay event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger canplay event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("canplay", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_canplaythrough.html b/tests/approved/audio/event_canplaythrough.html
--- a/tests/approved/audio/event_canplaythrough.html
+++ b/tests/approved/audio/event_canplaythrough.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - canplaythrough</title>
+  <title>audio events - canplaythrough</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger canplaythrough event", {timeout:60000});
+var t = async_test("setting src attribute on autoplay audio should trigger canplaythrough event", {timeout:60000});
var a = document.getElementById("a");
a.addEventListener("canplaythrough", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_loadeddata.html b/tests/approved/audio/event_loadeddata.html
--- a/tests/approved/audio/event_loadeddata.html
+++ b/tests/approved/audio/event_loadeddata.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - loadeddata</title>
+  <title>audio events - loadeddata</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger loadeddata event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger loadeddata event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("loadeddata", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_loadedmetadata.html b/tests/approved/audio/event_loadedmetadata.html
--- a/tests/approved/audio/event_loadedmetadata.html
+++ b/tests/approved/audio/event_loadedmetadata.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - loadedmetadata</title>
+  <title>audio events - loadedmetadata</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger loadedmetadata event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger loadedmetadata event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("loadedmetadata", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
});
diff --git a/tests/approved/audio/event_loadstart.html b/tests/approved/audio/event_loadstart.html
--- a/tests/approved/audio/event_loadstart.html
+++ b/tests/approved/audio/event_loadstart.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - loadstart</title>
+  <title>audio events - loadstart</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
  <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger loadstart event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger loadstart event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("loadstart", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_order_canplay_canplaythrough.html b/tests/approved/audio/event_order_canplay_canplaythrough.html
--- a/tests/approved/audio/event_order_canplay_canplaythrough.html
+++ b/tests/approved/audio/event_order_canplay_canplaythrough.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - canplay, then canplaythrough</title>
+  <title>audio events - canplay, then canplaythrough</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger canplay then canplaythrough event", {timeout:60000});
+var t = async_test("setting src attribute on autoplay audio should trigger canplay then canplaythrough event", {timeout:60000});
var a = document.getElementById("a");
var found_canplay = false;
a.addEventListener("canplay", function() {
   found_canplay = true;
});
a.addEventListener("canplaythrough", function() {
   t.step(function() {
    assert_true(found_canplay);
diff --git a/tests/approved/audio/event_order_canplay_playing.html b/tests/approved/audio/event_order_canplay_playing.html
--- a/tests/approved/audio/event_order_canplay_playing.html
+++ b/tests/approved/audio/event_order_canplay_playing.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - canplay, then playing</title>
+  <title>audio events - canplay, then playing</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger canplay then playing event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger canplay then playing event", {timeout:30000});
var a = document.getElementById("a");
var found_canplay = false;
a.addEventListener("canplay", function() {
   found_canplay = true;
});
a.addEventListener("playing", function() {
   t.step(function() {
    assert_true(found_canplay);
diff --git a/tests/approved/audio/event_order_loadedmetadata_loadeddata.html b/tests/approved/audio/event_order_loadedmetadata_loadeddata.html
--- a/tests/approved/audio/event_order_loadedmetadata_loadeddata.html
+++ b/tests/approved/audio/event_order_loadedmetadata_loadeddata.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - loadedmetadata, then loadeddata</title>
+  <title>audio events - loadedmetadata, then loadeddata</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger loadedmetadata then loadeddata event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger loadedmetadata then loadeddata event", {timeout:30000});
var a = document.getElementById("a");
var found_loadedmetadata = false;
a.addEventListener("loadedmetadata", function() {
   found_loadedmetadata = true;
});
a.addEventListener("loadeddata", function() {
   t.step(function() {
    assert_true(found_loadedmetadata);
diff --git a/tests/approved/audio/event_order_loadstart_progress.html b/tests/approved/audio/event_order_loadstart_progress.html
--- a/tests/approved/audio/event_order_loadstart_progress.html
+++ b/tests/approved/audio/event_order_loadstart_progress.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - loadstart, then progress</title>
+  <title>audio events - loadstart, then progress</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger loadstart then progress event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger loadstart then progress event", {timeout:30000});
var a = document.getElementById("a");
var found_loadstart = false;
a.addEventListener("loadstart", function() {
   found_loadstart = true;
});
a.addEventListener("progress", function() {
   t.step(function() {
    assert_true(found_loadstart);
diff --git a/tests/approved/audio/event_pause.html b/tests/approved/audio/event_pause.html
--- a/tests/approved/audio/event_pause.html
+++ b/tests/approved/audio/event_pause.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - pause</title>
+  <title>audio events - pause</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("calling pause() on autoplay video should trigger pause event", {timeout:30000});
+var t = async_test("calling pause() on autoplay audio should trigger pause event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("pause", function() {
  t.step(function() {
    assert_true(true);
   });
   t.done();
}, false);
a.src = getAudioURI("http://media.w3.org/2010/05/sound/sound_5") + "?" + new Date() + Math.random();
diff --git a/tests/approved/audio/event_play.html b/tests/approved/audio/event_play.html
--- a/tests/approved/audio/event_play.html
+++ b/tests/approved/audio/event_play.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - play</title>
+  <title>audio events - play</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger play event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger play event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("play", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_playing.html b/tests/approved/audio/event_playing.html
--- a/tests/approved/audio/event_playing.html
+++ b/tests/approved/audio/event_playing..html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - playing</title>
+  <title>audio events - playing</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger playing event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger playing event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("playing", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);
diff --git a/tests/approved/audio/event_progress.html b/tests/approved/audio/event_progress.html
--- a/tests/approved/audio/event_progress.html
+++ b/tests/approved/audio/event_progress.html
@@ -1,23 +1,23 @@
<!doctype html>
<html>
  <head>
-  <title>video events - progress</title>
+  <title>audio events - progress</title>
   <script src="/resources/testharness.js"></script>
   <script src="../../resources/testharnessreport.js"></script>
   <script src="../common/media.js"></script>
  </head>
  <body>
   <p><a href="http://dev.w3.org/html5/spec/Overview.html#mediaevents">spec reference</a></p>
-  <video id="a" autoplay controls>
-  </video>
+  <audio id="a" autoplay controls>
+  </audio>
   <div id="log"></div>
   <script>
-var t = async_test("setting src attribute on autoplay video should trigger progress event", {timeout:30000});
+var t = async_test("setting src attribute on autoplay audio should trigger progress event", {timeout:30000});
var a = document.getElementById("a");
a.addEventListener("progress", function() {
   t.step(function() {
    assert_true(true);
   });
   t.done();
   a.pause();
}, false);

Thanks,
Zhiqiang

Received on Tuesday, 31 July 2012 16:16:32 UTC