- From: Ms2ger <ms2ger@gmail.com>
- Date: Tue, 01 Nov 2011 11:08:49 +0100
- To: Kris Krueger <krisk@microsoft.com>
- CC: "'public-html-testsuite@w3.org'" <public-html-testsuite@w3.org>
Hi Kris, On 10/18/2011 04:50 PM, Kris Krueger wrote: > As part of the Test Review period, I looked at the cases submitted in the Mozilla folder. > Here is my feedback, looks like with a few updates they all can get approved unless someone objects. Thanks for your review. I've tried to address your comments: <https://dvcs.w3.org/hg/html/rev/ea538a8c15db>. > This case doesn't use the harness and doesn't look completed. > http://w3c-test.org/html/tests/submission/Mozilla/script-for-onload.html Fixed. > You should use video files from http://media.w3.org/2010/05/video/ and make sure they are browser agnostic. > http://w3c-test.org/html/tests/approved/video/event_loadeddata.html has an example how to do this using the media.js file. Haven't done that; it seems to add unnecessary verbosity to the test for no good reason. Indeed, the spec requires this behaviour for *any* video resource, not just those in a format the UA supports. > iFrames and dataURI's don't need to be used for these tests since they don't work in all browsers. That's a bug in these browsers, then. > Minor you should add a pointer to the spec for this case (http://dev.w3.org/html5/spec/Overview.html#handler-onload). > http://w3c-test.org/html/tests/submission/Mozilla/body-onload.html Done. HTH Ms2ger
Received on Tuesday, 1 November 2011 12:48:23 UTC