Roll in the various notes I'd made about menu construction into the algorithm. (whatwg r3299)

Roll in the various notes I'd made about menu construction into the
algorithm. (whatwg r3299)

http://dev.w3.org/cvsweb/html5/spec/Overview.html?r1=1.2445&r2=1.2446&f=h
http://html5.org/tools/web-apps-tracker?from=3298&to=3299

===================================================================
RCS file: /sources/public/html5/spec/Overview.html,v
retrieving revision 1.2445
retrieving revision 1.2446
diff -u -d -r1.2445 -r1.2446
--- Overview.html 17 Jun 2009 05:34:56 -0000 1.2445
+++ Overview.html 17 Jun 2009 05:52:54 -0000 1.2446
@@ -34467,17 +34467,17 @@
 
   <dl class="switch"><dt>An element that <a href="#concept-command" title="concept-command">defines a command</a></dt>
 
-   <dd>Append the command to the menu, respecting its <a href="#concept-facet" title="concept-facet">facets</a><!-- XXX be explicit about what
-   this means for each facet -->. <!--If the element is a
-   <code>command</code> element with a <code
-   title="attr-command-default">default</code> attribute, mark the
-   command as being a default command.--></dd> <!-- XXX if there's an
-   Icon facet for the command, it should be <span
-   title="fetch">fetched</span>, and then that image should be
-   associated with the command, such that each command only has its
-   image fetched once, to prevent changes to the base URL from having
-   effects after the image has been fetched once. (no need to resolve
-   the Icon facet, it's an absolute URL) -->
+   <dd>Append the command to the menu, respecting its <a href="#concept-facet" title="concept-facet">facets</a><!-- we might need to be
+   explicit about what this means for each facet, if testing shows
+   this isn't well-implemented. e.g.: If there's an Icon facet for the
+   command, it should be <span title="fetch">fetched</span>, and then
+   that image should be associated with the command, such that each
+   command only has its image fetched once, to prevent changes to the
+   base URL from having effects after the image has been fetched
+   once. (no need to resolve the Icon facet, it's an absolute URL)
+   -->. <!--If the element is a <code>command</code> element with a
+   <code title="attr-command-default">default</code> attribute, mark
+   the command as being a default command.--></dd>
 
 
    <dt>An <code><a href="#the-hr-element">hr</a></code> element</dt>
@@ -34490,8 +34490,9 @@
 
 
    <dt>An <code><a href="#the-li-element">li</a></code> element</dt>
+   <dt>A <code><a href="#the-label-element">label</a></code> element</dt>
 
-   <dd>Iterate over the children of the <code><a href="#the-li-element">li</a></code> element.</dd>
+   <dd>Iterate over the children of the element.</dd>
 
 
    <dt>A <code><a href="#menus">menu</a></code> element with no <code title="attr-menu-label"><a href="#attr-menu-label">label</a></code> attribute</dt>
@@ -34500,10 +34501,11 @@
    <dd>Append a separator to the menu, then iterate over the children
    of the <code><a href="#menus">menu</a></code> or <code><a href="#the-select-element">select</a></code> element, then
    append another separator.</dd>
+   <!-- v2: we might want to support <select> in <label> as giving a named submenu -->
 
 
    <dt>A <code><a href="#menus">menu</a></code> element with a <code title="attr-menu-label"><a href="#attr-menu-label">label</a></code> attribute</dt>
-   <dt>An <code><a href="#the-optgroup-element">optgroup</a></code> element</dt>
+   <dt>An <code><a href="#the-optgroup-element">optgroup</a></code> element with a <code title="attr-menu-label"><a href="#attr-menu-label">label</a></code> attribute</dt>
 
    <dd>Append a submenu to the menu, using the value of the element's
    <code title="">label</code> attribute as the label of the menu. The
@@ -34516,16 +34518,7 @@
 
    <dd><a href="#ignore">Ignore</a> the node.</dd>
 
-  </dl><p class="XXX">We should support <code><a href="#the-label-element">label</a></code> in the
-  algorithm above -- just iterate through the contents like with
-  <code><a href="#the-li-element">li</a></code>, to support <code><a href="#the-input-element">input</a></code> elements in
-  <code><a href="#the-label-element">label</a></code> elements. Also, <code><a href="#the-optgroup-element">optgroup</a></code> elements
-  without labels should be ignored (maybe? or at least should say they
-  have no label so that they are dropped below), and
-  <code><a href="#the-select-element">select</a></code> elements inside <code><a href="#the-label-element">label</a></code> elements may
-  need special processing.</p>
-
-  <p>Once all the nodes have been processed as described above, the
+  </dl><p>Once all the nodes have been processed as described above, the
   user agent must the post-process the menu as follows:</p>
 
   <ol><li>Any menu item with no label, or whose label is the empty string, must be removed.</li>

Received on Wednesday, 17 June 2009 05:53:43 UTC