Re: [css-houdini-drafts] [css-typed-om] type for hue angles (#1033)

I think there may be some confusion - there is no more specific JS type. All values with units are unified in a single type, CSSUnitValue, with CSSNumericValue as the superclass that allows for math functions to be represented. Angles are just a CSSUnitValue with one of the angle unit values, or a CSSNumericValue whose CSS type resolves to one of those units.

For example, note that the transform functions work the same way - all the arguments are CSSNumericValue, and we just check on constructing/setting that they resolve to the correct CSS type depending on the value.

(Oh whoops, I see I left out the text that verifies the value type on setting the h attribute in CSSLCH; it's meant to look the same as CSSHSL.)

-- 
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/css-houdini-drafts/issues/1033#issuecomment-839929515 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 12 May 2021 16:40:22 UTC