[css-houdini-drafts] [css-animation-worklet] Explainer feedback (#891)

domenic has just created a new issue for https://github.com/w3c/css-houdini-drafts:

== [css-animation-worklet] Explainer feedback ==
Hi @majido and others,

I did a quick pass through the explainer at https://github.com/w3c/css-houdini-drafts/blob/master/css-animationworklet/README.md and had some feedback that I thought might be helpful:

- The explainer does a great job of motivating the problem space and talking about the use cases we want to cover. It also positions itself well relative to existing solutions.

- Around the `#workletanimation` anchor, the explainer gets very technical, and almost spec-like. It introduces concepts in the abstract in a way that's hard for people new to the space to understand. I'd suggest instead front-loading the example code, and then explaining the code, including any of the concepts used.

- The examples assume a background understanding of the web animations API. Without this, some of the code inside `new WorkletAnimation()` seems pretty opaque. Why pass scrollTimeline twice? What are those KeyframeEffects doing? Perhaps a brief example without AnimationWorklet would help set the stage.

- Eventually I pieced together that most of the work is done by mutating the `effect` argument, but this was never stated anywhere explicitly.

- The explainer presents a coherent solution, but doesn't position it relative to any other solutions or alternatives. Were other designs considered? Were totally different primitives considered? The problems are well-stated, but how do we know this is the best solution out of the space of all possible ones?

- The example code includes various syntax errors, e.g. calling `curve()` instead of `this.curve()`, or using `$scrollingContainer` instead of `scrollingContainer` to refer to the element with that ID. These can be a bit confusing.

I hope this helps!

Please view or discuss this issue at https://github.com/w3c/css-houdini-drafts/issues/891 using your GitHub account

Received on Thursday, 16 May 2019 20:43:47 UTC