Re: [css-houdini-drafts] [css-properties-values-api] Consume a component name presumably shouldn't allow CSS wide keywords, but it does. (#879) from andruud via GitHub on 2019-04-29 (public-houdini-archive@w3.org from April 2019)

From: andruud via GitHub <sysbot+gh@w3.org>
Date: Mon, 29 Apr 2019 17:41:56 +0000
To: public-houdini-archive@w3.org
Message-ID: <issue_comment.created-487675199-1556559715-sysbot+gh@w3.org>

In my defense, my original PR handled this [[1]](https://github.com/w3c/css-houdini-drafts/pull/860/commits/641be53f3edc14fd1dd48537173e29c9eb81ce3a#diff-a9241a7d4da1a961238474fb2b99cdf1R629), but it got lost in Tab's pass over the text. (Thankfully section 3.1 still says "Any sequence which starts an identifier, can be consumed as a name, and matches the &lt;custom-ident> production", so at least there's that. We should still fix "Consume a syntax component", of course).

I don't remember right now if there's a test for this particular case. I *think* so, as I remember us having `expectations.txt` for something like this due to missing _revert_ support. I'll check tomorrow and add one if it's missing.

Related PR : #861

-- 
GitHub Notification of comment by andruud
Please view or discuss this issue at https://github.com/w3c/css-houdini-drafts/issues/879#issuecomment-487675199 using your GitHub account

Received on Monday, 29 April 2019 17:41:57 UTC