Re: [css-houdini-drafts] [css-properties-values-api] Define effects on CSSOM. (#873)

Did some minor tweaking to wording and linking, but nothing to the algos. Looks good otherwise, sorry for the delay in reviewing.

> CSS Typed OM seems to have a concept of underlying values "being" a certain type (rather than e.g. matching a production), in which case it should be fine.

Yeah, underlying values are an implementation-defined structure, that just must be able to reproduce the necessary data for reification/stringification. What you have down is fine; the only thing that's not a `<declaration-value>` but still a valid custom property value is the empty value, and that can't ever match a syntax, so it's fine to let that fall into the second case.

-- 
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/css-houdini-drafts/pull/873#issuecomment-486823843 using your GitHub account

Received on Thursday, 25 April 2019 20:21:51 UTC