- From: David Dorwin <ddorwin@google.com>
- Date: Wed, 20 Jul 2016 12:54:54 -0700
- To: Mark Watson <watsonm@netflix.com>
- Cc: Greg Rutz <G.Rutz@cablelabs.com>, "Matthew Wolenetz <wolenetz@google.com> (wolenetz@google.com)" <wolenetz@google.com>, "Jerry Smith (WPT)" <jdsmith@microsoft.com>, "Philippe Le Hegaret (plh@w3.org)" <plh@w3.org>, Francois Daoust <fd@w3.org>, "public-hme-editors@w3.org" <public-hme-editors@w3.org>, Iraj Sodagar <irajs@microsoft.com>, John Simmons <johnsim@microsoft.com>, Paul Cotton <Paul.Cotton@microsoft.com>, Sukhmal Kommidi <skommidi@netflix.com>
- Message-ID: <CAHD2rsh7hoXmzF7tgzJLyT=cBWR4e-djeWg1SR+d4+=yRQAnWA@mail.gmail.com>
My thoughts (I have not looked at the new test): - I hope to push some improvements to the Google tests by EOD based on https://codereview.chromium.org/2084053002/. These bring the tests closer to supporting fully compliant implementations and lay the groundwork for supporting other content types as previously discussed. I suggest waiting for this before moving files anywhere. - We should move files out of the Google directory as we find permanent use and homes for them. In some cases, that might be for Clear Key tests (see below) while others may be converted to support multiple DRMs. (Some may be duplicated to support both.) - I agree that most of our tests should work with Clear Key as well as commercial systems. However, I think for our implementation report, we should ensure the tests ran with commercial systems. Unless there is an easy way to generate a report with separate entries for Clear Key and any commercial system, we may want to hold off on actually enabling Clear Key in these tests. - Since Clear Key is a specific feature in the spec, we should also have tests that only work with Clear Key and specifically test it, including the license format, etc. Such tests should be explicitly named "Clear Key" in some way - probably either in a clearkey directory or with "-clearkey-" in the name. - For playback and other things in the general tests, we could try to reuse the tests somehow rather than duplicating them for Clear Key. I'm not sure how best to do that. I think this is closer to Mark's (A) but with more uncertainty. I'm explicitly avoiding (B) for now unless/until we can provide clarity in the implementation report. On Wed, Jul 20, 2016 at 12:30 PM, Mark Watson <watsonm@netflix.com> wrote: > So, what we have right now is: > (1) A large number of ClearKey-only tests in a "Google" folder, and > (2) One of those tests (basic playback) migrated to DRM Today, in the root > folder > > There are two approaches: > (A) Keep ClearKey and DRM tests separate: move the "Google" tests into the > root or a "clearkey" folder, continue making new DRMToday versions of each > of those ClearKey tests > (B) Make the DRMToday test also support ClearKey, continue making new > ClearKey+DRMToday versions of each of the Google tests and, eventually, > drop the Google folder > > For (B), we need to run two tests in one file, which requires some care > with async tests and there's been comments that we should not have multiple > tests in one file. > > Opinions ? > > ...Mark > > > > > > On Wed, Jul 20, 2016 at 11:27 AM, Greg Rutz <G.Rutz@cablelabs.com> wrote: > >> I think the test utilities should be designed to be as DRM-independent as >> possible. This would allow us to run any of the test cases that apply to >> ClearKey simply by providing a DRMConfig and test content that indicates >> use of ClearKey. I apologize that I have not been following the EME spec >> progression that much over the last 12-18 months, but I recall there not >> being a ton of differences between ClearKey support and other DRMs as I >> implemented it in dash.js. >> >> For test cases that are valid for ClearKey, the test case would simply >> execute multiple times on the UA under test — once with ClearKey content >> and one or more additional times for the “real” DRMs that are to be tested >> on that UA. No sense in maintaining separate test code if we don’t have to. >> >> G >> >> On 7/20/16, 10:34 AM, "Mark Watson" <watsonm@netflix.com> wrote: >> >> Question: should we expand this test case to cover ClearKey ? Or will we >> rely on the tests in the Google folder for ClearKey ? >> >> If the latter, should we move those tests into the main directory (I see >> they are now working) ? Or, if others would like to add ClearKey tests, >> should they add them to the Google folder ? >> >> ...Mark >> >> On Tue, Jul 19, 2016 at 7:18 PM, Mark Watson <watsonm@netflix.com> wrote: >> >>> All, >>> >>> Sukhmal has created a Pull Request for a temporary session test case >>> using DRM Today. We have tested this on Chrome with Widevine and it should >>> work on Edge with PlayReady as well: >>> >>> https://github.com/w3c/web-platform-tests/pull/3313 >>> >>> Please review this and comment on whether it is a good template / model >>> for us to work from. We can quickly migrate more of the Google clearkey >>> tests to drmtoday as well as implementing tests for other session types >>> based on this model. >>> >>> ...Mark >>> >> >> >
Received on Wednesday, 20 July 2016 19:55:43 UTC