- From: Afterlifepro via GitHub <noreply@w3.org>
- Date: Sat, 05 Jul 2025 10:44:52 +0000
- To: public-fxtf-archive@w3.org
Throwing in my 2 cents on the questions at the bottom of the issue: - I dont see any reason for it to be a DOMRectReadOnly over a DOMRect as it doesn't have a relation to the intersection, although I dont see a real reason to use DOMRect instead, so I think either is fine unless im missing some semantic meaning of DOMRectReadOnly - I think the acceptable arguments should probably try to be as generic as possible to remove friction (ie: allow the `DOMPoint*`, double x double y, `MouseEvent`, and etc etc) - I think moving it all to be static functions would make sense, since it would allow use for custom hitboxes in a game (via canvas) Also another note after thinking on this: the `intersects` and `intersection` methods should absolutely have more distinct names to avoid confusion when skimming code; maybe `intersects` and `intersectionRect` or something (also makes clear it returns a rect over a bool like everything else) -- GitHub Notification of comment by Afterlifepro Please view or discuss this issue at https://github.com/w3c/fxtf-drafts/issues/602#issuecomment-3038746771 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Saturday, 5 July 2025 10:44:53 UTC