W3C home > Mailing lists > Public > public-fxtf-archive@w3.org > June 2019

[fxtf-drafts] [geometry] DOMMatrix scaleSelf() step 6 has a redundant originZ check (#350)

From: Kagami Sascha Rosylight via GitHub <sysbot+gh@w3.org>
Date: Fri, 28 Jun 2019 08:32:57 +0000
To: public-fxtf-archive@w3.org
Message-ID: <issues.opened-461921365-1561710776-sysbot+gh@w3.org>
saschanaz has just created a new issue for https://github.com/w3c/fxtf-drafts:

== [geometry] DOMMatrix scaleSelf() step 6 has a redundant originZ check ==
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

`scaleSelf()` step 6 says:

>If _scaleZ_ is not 1 or _originZ_ is not 0 or -0, set is 2D of the current matrix to false.

But the originZ check is redundant because `scaleSelf()` internally calls `translateSelf()` which does that check already.

I think we can remove the check, thoughts?

cc @bzbarsky 

Please view or discuss this issue at https://github.com/w3c/fxtf-drafts/issues/350 using your GitHub account
Received on Friday, 28 June 2019 08:32:58 UTC

This archive was generated by hypermail 2.3.1 : Friday, 28 June 2019 08:32:59 UTC