W3C home > Mailing lists > Public > public-fxtf-archive@w3.org > May 2017

Re: [fxtf-drafts] [geometry] "interface DOMRect" should have alias for ClientRect

From: Simon Pieters via GitHub <sysbot+gh@w3.org>
Date: Thu, 18 May 2017 08:06:21 +0000
To: public-fxtf-archive@w3.org
Message-ID: <issue_comment.created-302332055-1495094780-sysbot+gh@w3.org>
@foolip mentioned in the Chromium bug that Gecko has only `DOMRect`, not `ClientRect`.

httparchive search for `.{50}\bClientRect\b.{50}` and grouping the matches:

num | match
----|------
108 | `.i.x$(a)\|\|vdb.i.E$(a)},IT:function(a){return c(a,"ClientRect")\|\|c(a,"DOMRect")},hj:function(a){return void 0!=`
4 | `.waa(a)\|\|vdb.i.Caa(a)},EU:function(a){return c(a,"ClientRect")\|\|c(a,"DOMRect")},yj:function(a){return void 0!=`
2 | `.info("bcTruncate: browser doesn't have Range and ClientRect support; aborting");return}var elems=this.filter(`
2 | `.aea(a)\|\|vdb.i.gea(a)},iX:function(a){return c(a,"ClientRect")\|\|c(a,"DOMRect")},Pj:function(a){return void 0!=`
1 | `:this},bcr:{value:l\|\|g.exports.ClientRect.getBoundClientRect(document.body)},origin:{value:o\|\|new g.exports.Po`
1 | `("./SSiteNav").SSiteNav,ClientRect=requirejs("lib/ClientRect"),env=require("./environment"),cssCompat=require(`
1 | `","lib/Model","lib/ZenView","lib/StyleSheet","lib/ClientRect","lib/Cookie","modules/rlx-transition","modules/r`
1 | `.join(", ")+"]";break;case"ApplicationCache":case"ClientRect":case"DOMApplicationCache":case"DOMStringList":ca`
1 | `&&d!=null){b.value=a.Width;d.value=a.Height}}this.ClientRect=new Rect(0,0,a.Width,a.Height);this.Rect=CopyRect`
1 | `\n    new(): CharacterData;\r\n}\r\n\r\ninterface ClientRect {\r\n    bottom: number;\r\n    readonly height: `
1 | ` strict";var klass=require("mbx/src/class").class,ClientRect=require("mbx/src/dom/ClientRect").ClientRect,Even`


The `.info("bcTruncate: browser doesn't have Range and ClientRect support; aborting");return}var elems=this.filter(` match looks a bit worrying, but it's actually checking this:

```
hasCSSOM:{className:"cssom",test:function(){return document.createRange&&
document.createRange().getClientRects}}
```
http://s4.bcbits.com/tmpdata/cache/global_head_bundle_min_313e367f1f56dfa01981fc3f0ed4396b.js
from site http://lapfoxtrax.com/

Nothing there looks like it's trying to identify Gecko.

Most of the other matches seem to already account for `DOMRect`, so I think we should try not having a `ClientRect` alias.

-- 
GitHub Notification of comment by zcorpan
Please view or discuss this issue at https://github.com/w3c/fxtf-drafts/issues/163#issuecomment-302332055 using your GitHub account
Received on Thursday, 18 May 2017 08:06:29 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 20 November 2018 00:45:58 UTC