Re: [geometry] DOMMatrix.rotateAxisAngleSelf()

On Sun, Aug 24, 2014 at 12:47 AM, 방진호 <jinho.bang@samsung.com> wrote:

>  Dear all,
>
>
>
> I've found a small bug while I was implementing
> DOMMatrix.rotateAxisAngleSelf(x, y, z, angle).
>
>
>
> According to the spec..
> http://dev.w3.org/fxtf/geometry/#dom-dommatrix-rotateaxisangleself
>
>
>
> "If z is not 0, set is2D of the current matrix to false."
>
>
>
> It seems to be incorrect.
>
>
>
> If there is only z-axis rotation without x-axis or y-axis rotation, it
> will be 2D rotation.
>
>
>
> For example, rotateAxisAngle(0, 0, 1, angle) is the same with
> rotate(angle).
>
>
>
> So, I think the spec should be fixed as follows.
>
>
>
> "If x is not 0 or y is not 0, set is2D of the current matrix to false."
>
>
>
> What do you think?
>

Hi Jinho,

thanks for bringing this up. I updated the spec to reflect your suggestions
[1]

Rik

1: http://dev.w3.org/fxtf/geometry/#dom-dommatrix-rotateaxisangleself