W3C home > Mailing lists > Public > public-fx@w3.org > April to June 2014

Re: [geometry] Review request

From: Dirk Schulze <dschulze@adobe.com>
Date: Mon, 2 Jun 2014 15:14:37 +0000
To: Kari Pihkala <kari.pihkala@gmail.com>
CC: FX <public-fx@w3.org>
Message-ID: <6BAAF7A9-D9CB-41CE-8F84-C4CB4C44E427@adobe.com>
Hi Kari,

> On May 30, 2014, at 12:03 PM, "Kari Pihkala" <kari.pihkala@gmail.com> wrote:
> I think there are few exception cases missing in the DOMMatrix:
> - SVGMatrix.rotateFromVector() can raise an exception, should
> DOMMatrix.rotateFromVector() and rotateFromVectorBy() also raise
> exceptions if values are invalid?

You are right that SVGMatrix throw an exception. For SVG2 we already decided to change the behavior. DOMMatrix says: "If x and y should both be zero, the angle is specified as zero.". [1]

> - DOMMatrix.inverse() raises an exception if the matrix is
> non-invertible, should DOMMatrix.invert() also do it?

Yes, that was an oversight. Thanks.

> - can DOMMatrix.rotateAxisAngle() and rotateAxisAngleBy() fail? What
> if x, y, and z are zero?

The behavior is defined by the matrix in [2]. No exception necessary.

Thanks a lot for the review!


> BR,
> Kari

[1] http://dev.w3.org/fxtf/geometry/#dom-dommatrixreadonly-rotatefromvector
[2] http://www.w3.org/TR/2012/WD-css3-transforms-20120911/#Rotate3dDefined
Received on Monday, 2 June 2014 15:15:15 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:49:49 UTC