Re: ACTION-1947 - Import the XPath 3.0 serialize() function to XForms 2.0

Overall this looks good. But I have the following comments:

* Shouldn't the default value for xforms:relevant be true (currently specified value is false)
* How can you validate non relevant nodes? I would expect that non-relevant nodes are considered valid when doing validation on serialisation.
* What is the default value of the xforms:validate serialisation parameter
* Could we rephrase 'When <code>true</code>, nodes marked as invalid in the input sequence are checked (after pruning if pruning is enabled with <code>xforms:relevant</code>). If there is any invalid node, the function raises a dynamic error. No revalidation takes place during this process.'
      *Proposal*: When <code>true</code>, the function raises a dynamic error if there are any nodes marked as invalid in the input sequence (after pruning if pruning is enabled with <code>xforms:relevant</code>). No revalidation takes place during this process.

Kind regards,

Nick Van den Bleeken
R&D Manager

Phone: +32 3 425 41 02
Office fax: +32 3 821 01 71
nick.van.den.bleeken@inventivegroup.com<mailto:nick.van.den.bleeken@inventivegroup.com>
www.inventivedesigners.com


[cid:image001.png@01CBF2F8.1DA19110][cid:image002.png@01CBF2F8.1DA19110][cid:image003.png@01CBF2F8.1DA19110]

On 29 May 2013, at 03:31, Erik Bruchez <erik@bruchez.org<mailto:erik@bruchez.org>> wrote:

All,

As per this action item, I imported the function into XForms. I did so:

- by referring to the external specifications
- and using XSLT and XQuery Serialization 3.0's ability to add
submission methods and parameters to specify behavior which is
specific to XForms.

Here is the diff:

http://www.w3.org/MarkUp/Forms/wiki/index.php?title=XPath_Expressions_Module&diff=3800&oldid=3750

This means some changes compared with the previous text, including:

- the function signatures have changed
- the way to specify parameters (including the serialization method) has changed

I have a few open questions/comments:

- Most standard boolean serialization parameters are "yes" and "no".
Should we use that too, or "true" and "false"? Or accept both?
- There are 2 editorial notes related to linking.
- I chose to raise a dynamic error if JSON serialization fails. It can
fail, right?
- Is it unexpected to users that, by default, non-relevant nodes are
pruned? This is consistent with xforms:submission
- I made xxforms:validate throw a dynamic error. It seems better than
returning a blank string.

Comments welcome.

-Erik





________________________________

Inventive Designers' Email Disclaimer:
http://www.inventivedesigners.com/email-disclaimer