- From: Christophe Guéret <christophe.gueret@gmail.com>
- Date: Mon, 28 Nov 2016 13:38:27 +0000
- To: Bernadette Farias Lóscio <bfl@cin.ufpe.br>
- Cc: W3C DWBP WG - Comments <public-dwbp-comments@w3.org>, Phil Archer <phila@w3.org>
- Message-ID: <CABP9CAFAEAy6rGMUGdECD-bKSx1dtYM8bPsJQDF4X8+jEvDtcA@mail.gmail.com>
Hi Bernadette, Thanks for considering all the comments :-) As you saw I just commented further (at the bottom) on your comment "e70fc2c <https://github.com/w3c/dwbp/commit/e70fc2cba67d453b7e6d163cffb68a14bf83cb5a> I used the http://www.geonames.org/3399415 and it worked. Is it really necessary to change?"because I think that the change is indeed needed to get working LD links. Regarding "c7496c2 <https://github.com/w3c/dwbp/commit/c7496c219747b2138ccb7d1570a1880cb210de51> The example shows the inclusion of the locale parameters metadata, followed by a locale-neutral representation of bus fare data. The example has to parts: one that shows that metadata and the other one to show an example of representation. I suggest to leave it like this." I understand these are two different parts but still think it's confusing to see them together. Maybe you could just split that code into two <pre> ? Best Regards, Christophe On 28 November 2016 at 12:41, Bernadette Farias Lóscio <bfl@cin.ufpe.br> wrote: > Hi Christophe, > > Thanks a lot for your detailed review! I checked each one of the commits > and most of them are editorial changes and can easily be incorporated on > the document. > > I'd like to kindly ask you to take a look on comments that I included on > the pull request [1] and please let me know if you are ok with them. > > kind regards, > Bernadette > > [1] https://github.com/w3c/dwbp/pull/474 > > 2016-10-06 19:46 GMT-03:00 Christophe Guéret <christophe.gueret@gmail.com> > : > >> Dear everyone, >> >> Congrats on all the great work :-) >> >> I have (finally !) been through the latest draft of the best practices >> and made a number of comments which I just proposed with a pull request ( >> https://github.com/w3c/dwbp/pull/474). Hope you will find those useful. >> >> Cheers, >> Christophe >> > > > > -- > Bernadette Farias Lóscio > Centro de Informática > Universidade Federal de Pernambuco - UFPE, Brazil > ------------------------------------------------------------ > ---------------- >
Received on Monday, 28 November 2016 13:39:23 UTC