Re: DAP-ACTION-730: Ask zhiqiang to update the battery test suite to match latest battery spec (coordinating with marcos)

Hi Zhiqiang,

> On 23 Jan 2015, at 08:53, Zhang, Zhiqiang <zhiqiang.zhang@intel.com> wrote:
> 
> Hi,
> 
> The battery test suite is updating at
> https://github.com/w3c/web-platform-tests/pull/1488
> ... with my review at
> https://critic.hoppipolla.co.uk/r/3589
> 
> Any review and help is welcome.
> 
> Also, I've accepted a test checking "navigator.getBattery()'s returnvalue is Promise<BatteryManager>" at
> https://github.com/w3c/web-platform-tests/pull/1465
> 
> Will let you know immediately when the update is finished.

Thanks for the update. I ran the tests with Chrome 40.0.2214.93 on OS X. Some observations:

* battery-created-manual.html

The assertion has been updated in the latest CR [1] and should be updated, for the updated assertion see [2].

* battery-charging-manual.html
* battery-discharging-manual.html

I'm wondering if the timeout should be increased in these tests since e.g. in battery-discharging-manual.html I got the following error message I suspect is due to premature timeout:

[[

assert_less_than: The value of the level attribute must decrease expected a number but got a "undefined"

]]

It may be also useful to indicate to the user that the test is running and not hung while waiting for the onlevelchange.

* battery-full-manual.html

Pass.

* battery-interface-idlharness.html
* battery-interface.html

These tests are per the old spec, to be updated. If we can get good enough coverage with the idlharness only, we can actually drop battery-interface.html and update the battery-interface-idlharness.html per the latest CR.

* battery-promise.html

Pass.

* battery-plugged-in-manual.html
* battery-unplugged-manual.html

To be updated to the latest CR.

Thanks Zhiqiang and others who've contributed updated test cases. Further contributions are very welcome to update the test suite so we could move to the PR next.

Thanks,

-Anssi

[1] http://www.w3.org/TR/2014/CR-battery-status-20141209/
[2] http://www.w3.org/TR/2014/CR-battery-status-20141209/#dfn-create-a-new-batterymanager-object

Received on Wednesday, 4 February 2015 12:18:12 UTC