Re: [ambient-light] Drop own powerful feature, require active local video source. (#83)

Hey @noamr, thanks for the comments. The more feedback we get about this change, the better.

> Some drive-by comments (I'm not a reviewer to either of these specs, but I ran into it at the W3C permissions workshop):
> 
> * Usually I read "editorial" as changing wording without changing meaning/behavior. This seems like a big change in behavior. Are we using the word differently in different specs?

My bad. Looking at https://www.w3.org/2021/Process-20211102/#correction-classes again it does look like "editorial" does not apply here. I've updated the PR title and the relevant commit messages.

> [...]
>
> Suggestion: If the idea here is that you'd get an ambient-light stream together with your video stream (which is kind of how I understand this change, with the only example provided), perhaps a more direct way to do it is that AL would be an additional [MediaStreamTrack](https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack) rather than a bespoke JS API? I think this still has some privacy/permission issues, but at least it would be more purpose-driven than capability-driven.

The idea of integrating ALS into getUserMedia() was discussed in https://github.com/w3c/ambient-light/issues/64#issuecomment-817129135 and https://github.com/w3c/ambient-light/issues/79#issuecomment-1175960515.

At the very least, this would require much bigger changes in the (current) implementation, as `//services/device/generic_sensor` and the Media Capture stack in Chromium do not communicate at all. There's also the question of whether data should be provided as a stream or only when a certain threshold is reached. Finally, if we define a new MediaStreamTrack type for ALS and require developers to do something like `getUserMedia({video: true, als: true})`, don't you end up in the same situation where you need to figure out a way to prompt users for access and explain to them what an ambient light sensor is?

You raise some interesting points about why an ALS shouldn't be treated like a camera, but I'd like to understand if going down the getUserMedia() route really makes sense or not.

-- 
GitHub Notification of comment by rakuco
Please view or discuss this issue at https://github.com/w3c/ambient-light/pull/83#issuecomment-1358061567 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 19 December 2022 18:19:03 UTC