- From: Daniel Fahl via GitHub <sysbot+gh@w3.org>
- Date: Wed, 29 Sep 2021 06:56:23 +0000
- To: public-device-apis-log@w3.org
> > @marcoscaceres would you suggest having the feature in both places?
>
> Yes. I think it should be possible to request screen wake lock with full brightness without going full screen.
I absolutely agree that it's sensible to have screen brightness adjustment combined with the wake lock mechanism - however I'm not sure about the other way around.
This however leads me to think there might be good reasons to encapsule this feature into it's own API (separation of concerns), however there are excellent arguments against that, as @mounirlamouri and others [commented earlier](https://github.com/w3c/screen-wake-lock/issues/129#issuecomment-440011878). To me it feels much more natural to have it accessible together with `navigator.wakeLock.request("screen", { brightness: "maximise" })` as opposed to `element.requestFullscreen({ brightness: "maximise" })` (even though there already is an `options` object that could be used as well...)
--
GitHub Notification of comment by daniel-fahl
Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/issues/129#issuecomment-929890738 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 29 September 2021 06:56:24 UTC