Re: [wake-lock] WakeLock.request() returns a promise that never resolves (#226)

> What is the point of the event giving you the WakeLockSentinel? 

So you can check the type.

> Maybe it would be better to give the reason why it was released?

Why it was released none of the apps business. 


> But then again, if I call release() myself, I am not very interested in that event, 

Sure, but other code might be. 

> so maybe a systemrelease event would make more sense?

IMO no, because you can get the type from the sentinel. Then we don't need to add new event names. We just use "release". 

-- 
GitHub Notification of comment by marcoscaceres
Please view or discuss this issue at https://github.com/w3c/wake-lock/issues/226#issuecomment-535445725 using your GitHub account

Received on Thursday, 26 September 2019 10:39:54 UTC