W3C home > Mailing lists > Public > public-device-apis-log@w3.org > May 2019

Re: [wake-lock] request(): Order for permission and other checks (#202)

From: Kenneth Rohde Christiansen via GitHub <sysbot+gh@w3.org>
Date: Mon, 13 May 2019 20:16:44 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-491969975-1557778603-sysbot+gh@w3.org>
I would do feature-policy early to avoid unnecessary work, and as @annevk said, try to at least group the exceptions if possible.

I was trying to do aborting as soon after as possible and before any async operation (like showing a dialog) but as we have multiple potential async operations (permission dialog, requesting the platform wake lock etc) then we would have to check it before each of these. 

GitHub Notification of comment by kenchris
Please view or discuss this issue at https://github.com/w3c/wake-lock/issues/202#issuecomment-491969975 using your GitHub account
Received on Monday, 13 May 2019 20:16:46 UTC

This archive was generated by hypermail 2.4.0 : Monday, 4 July 2022 12:47:56 UTC