W3C home > Mailing lists > Public > public-device-apis-log@w3.org > September 2018

Re: [sensors] Introduce WebDriver extension API

From: Wanming Lin via GitHub <sysbot+gh@w3.org>
Date: Thu, 13 Sep 2018 13:00:47 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-420997898-1536843645-sysbot+gh@w3.org>
> when the tests are run in Chromium's CI and run_web_tests.py (or rather just not via wptrunner) testdriver-vendor.js is used instead (and there's no WebDriver involved). 

Aha, I get your point now. :) You were talking about the testdriver-vendor.js at [here](https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testdriver-vendor.js?q=testdriver-vendor&sq=package:chromium&dr), right? Yes, it's nothing to do with WebDriver, but that's indeed a problem to make things consistent.  And we have to keep both approaches(Test API and WebDriver) to build conformance test suites between Chromium's CI  and WPT, that's what we've done for e.g. `test_driver.click()`. 
Current Test API(`initialize_generic_sensor_tests()`..) should definitely be refactored to `test_driver` like API if we accept this WebDriver extension API.





-- 
GitHub Notification of comment by Honry
Please view or discuss this issue at https://github.com/w3c/sensors/pull/369#issuecomment-420997898 using your GitHub account
Received on Thursday, 13 September 2018 13:00:49 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 13 September 2018 13:00:50 UTC