W3C home > Mailing lists > Public > public-device-apis-log@w3.org > September 2018

Re: [sensors] Introduce WebDriver extension API

From: Wanming Lin via GitHub <sysbot+gh@w3.org>
Date: Thu, 06 Sep 2018 05:36:51 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-418970347-1536212210-sysbot+gh@w3.org>
A _mock_ variable sounds good to me!

> 5. Let all the _type_ of [Sensor ](https://w3c.github.io/sensors/#sensor) objects' associated [platform sensor ](https://w3c.github.io/sensors/#concept-platform-sensor) be the _type_'s associated [mock sensor](https://github.com/w3c/sensors/pull/369#mock-sensor).

For this phrase, can probably be improved as: 
> 1. Let _sensor_instance_ be _type_ of Sensor object.
> 5. Set _sensor_instance_' associated [platform sensor](https://w3c.github.io/sensors/#concept-platform-sensor) to _mock_.

Does that make sense to you?

> To be honest, this is pushing my understanding of spec conventions. I think that because these values are not exposed to JavaScript, it's unnecessary to use internal slots. In this case, it may be enough to add text like, "A mock sensor has an associated mock sensor type [...]". The other reviewers can probably answer this question definitively.

Let's keep this as is if there's no more definitive answer from other reviewers. :)

-- 
GitHub Notification of comment by Honry
Please view or discuss this issue at https://github.com/w3c/sensors/pull/369#issuecomment-418970347 using your GitHub account
Received on Thursday, 6 September 2018 05:36:52 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 6 September 2018 05:36:53 UTC