W3C home > Mailing lists > Public > public-device-apis-log@w3.org > November 2017

Re: [wake-lock] [meta] web-platform-tests

From: Andrey Logvinov via GitHub <sysbot+gh@w3.org>
Date: Thu, 23 Nov 2017 09:46:50 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-346571367-1511430409-sysbot+gh@w3.org>
I've done a quick review and found the following:

1. Wake lock objects independent test does not reflect the spec intent. Created an issue https://github.com/w3c/web-platform-tests/issues/8411

2. A test is needed that Navigator.getWakeLock() is idempotent for the same Document, i.e. it will resolve with the same object (if it will not reject) no matter how many times it is called.

3. An independence test is needed for WakeLockRequest objects, i.e. that WakeLock.createRequest always creates a new request objects. 

-- 
GitHub Notification of comment by andrey-logvinov
Please view or discuss this issue at https://github.com/w3c/wake-lock/issues/111#issuecomment-346571367 using your GitHub account
Received on Thursday, 23 November 2017 09:46:55 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 23 November 2017 09:46:55 UTC