Re: [community-group] Typography type feedback (#102)

My personal feedback (even though some of this has already been mentioned above):
- lineHeight should allow numer AND dimension type values, so that absolute values are supported, not just relative to fontSize
- the spec must be clear about which properties are optional versus required, if everything is optional, is `{ }` a valid value? meaning everything is inherited..? technically speaking that is still a design decision so it seems like a valid typography design token to me
- translation tools are going to have a tough time with this token type in particular, if they want to export it to platforms using shorthand string values such as CSS Font, which makes family and size mandatory, and only includes a couple of other properties, definitely not things like word-spacing, kerning/letter-spacing or text-color. This is fine, we can expand object-value tokens into separate output values for each prop instead of using a shorthand that doesn't exactly align with the typography token's restrictions/scope. This definitely bloats the output a bit though and makes the exported tokens more tedious to apply to a coded component. I don't think that means the spec should change by any means, I just wanted to share this perspective.

-- 
GitHub Notification of comment by jorenbroekema
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/102#issuecomment-2097880031 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 7 May 2024 09:39:32 UTC