- From: James Nash via GitHub <sysbot+gh@w3.org>
- Date: Tue, 03 Jan 2023 22:22:54 +0000
- To: public-design-tokens-log@w3.org
c1rrus has just submitted a new pull request for https://github.com/design-tokens/community-group:
== Removes JSON types and makes absence of (inherited) $type invalid ==
Closes #120, #139
* Removes support for the JSON types (`string`, `boolean`, `null`, etc.)
* Except for `number` which is now documented as one of the spec's types. This is because it was required by the `gradient` type.
* Changes the type resolution rules so that when there is no (inherited) `$type` present, a token must be considered invalid. Previously, it would fall back on to one of the JSON types.
* Fixes a bug (?) in the `typography` type, where `lineHeight` expected a `string` value.
* I had to change this since `string` no longer exists. But also, it was never a useful type of value for that purpose. I've changed it to expect either `dimension` or `number` values for now. We can always revise it if needed once we review and action the feedback provided in #102
See https://github.com/design-tokens/community-group/pull/201
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 3 January 2023 22:22:55 UTC