- From: James Nash via GitHub <sysbot+gh@w3.org>
- Date: Tue, 07 Feb 2023 17:11:49 +0000
- To: public-design-tokens-log@w3.org
c1rrus has just merged c1rrus's pull request 201 for https://github.com/design-tokens/community-group: == Removes JSON types and makes absence of (inherited) $type invalid == Closes #120, #139 * Removes support for the JSON types (`string`, `boolean`, `null`, etc.) * Except for `number` which is now documented as one of the spec's types. This is because it was required by the `gradient` type. * Changes the type resolution rules so that when there is no (inherited) `$type` present, a token must be considered invalid. Previously, it would fall back on to one of the JSON types. * Fixes a bug (?) in the `typography` type, where `lineHeight` expected a `string` value. * I had to change this since `string` no longer exists. But also, it was never a useful type of value for that purpose. I've changed it to expect `number` values for now. We can always revise it if needed once we review and action the feedback provided in #102 * Updates examples throughout the spec to ensure that they are valid now that the JSON types and associated type resolution fallback behaviour have been removed. See https://github.com/design-tokens/community-group/pull/201 -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 7 February 2023 17:11:50 UTC