- From: Christian Hansen via GitHub <sysbot+gh@w3.org>
- Date: Mon, 19 Sep 2022 15:48:39 +0000
- To: public-design-tokens-log@w3.org
Why do the Typography values use "fontFamily" instead of "family"?
When comparing, e.g. shadow to typography I see that shadow's values are more context-based, but when writing typography, it's more based on the CSS properties.
```json
"microcopy": {
"$type": "typography",
"$value": {
"fontFamily": "{font.serif}",
"fontSize": "{font.size.smallest}",
"fontWeight": "{font.weight.normal}",
"letterSpacing": "0px",
"lineHeight": "1"
}```
We could make it more context based so it matches the other types in the spec by replacing some of the keys like this?
```json
"microcopy": {
"$type": "typography",
"$value": {
"family": "{font.serif}",
"size": "{font.size.smallest}",
"weight": "{font.weight.normal}",
"spacing": "0px",
"height": "1"
}```
The only problem I encounter is the height property's meaning since we removed the "letter" part.
--
GitHub Notification of comment by ch99q
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/102#issuecomment-1251206302 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 19 September 2022 15:48:41 UTC