- From: Ryan Johnson via GitHub <sysbot+gh@w3.org>
- Date: Wed, 30 Nov 2022 20:16:55 +0000
- To: public-design-tokens-log@w3.org
The problem with disallowing custom properties on JSON objects is that you break the entire spec, because any JSON object property that doesn't begin with `$` is thus invalid. This means that any token you define would be ignored and any named groups or subgroups would be ignored. Personally, I don't think there's any harm in adding extra properties, because the only ones that tools should care about are: 1. props beginning with `$` 2. props corresponding to groups/subgroups 3. props corresponding to tokens. Every other property is irrelevant. The only other way to achieve the above would be to have explicit `$groups` and `$tokens` props, to define our groups, subgroups and tokens. ----- FYI: For the tool that I'm building to parse Token JSON documents, I normalize group and token configs by excluding any property that doesn't begin with `$`. -- GitHub Notification of comment by CITguy Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/174#issuecomment-1332690086 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 30 November 2022 20:16:57 UTC