Re: [community-group] Remove JSON derived types from the specification (#120)

Thanks all for the additional comments. The editors have re-reviewed this issue and come to the conclusion that, _yes_, we should remove the JSON types after all! :-)

* As others have pointed out, most of the raw JSON types don't have obvious applications in UI design
    * Possble exceptions to this are `number` (e.g. for unitless line heights) and `string` (e.g. for microcopy like company names, slogans, etc.). We will therefore separately explore adding new types into the spec to cover those kinds of things.
* Since we've also [decided to no longer fallback on JSON types when no `$type` property is present on the token or its parent groups](https://github.com/design-tokens/community-group/issues/139#issuecomment-1331346032), they're no longer needed for that
* As per the comments above, using JSON types together with `$extensions` as a means of creating proprietary types is problematic. Since they'd still be "valid" tokens, other tools may have interpreted them in unintended ways if they didn't also understand the `$extension`.
    * We do however think it's useful for the spec to provide a means of defining proprietary types[^1], so I'll open a separate issue to discuss that (FWIW, something along the lines of what @romainmenke and @CITguy have proposed above like `$type` values that contain periods - `"$type": "com.example.custom-type" - looks promising for this)

I'll leave this issue open until we've made and merged a PR that updates the spec accordingly.


[^1]: Though, similar to `$extensions`, usage of such a feature should be for exceptional cases only. We intend to add some guidance into the spec's wording to make that clear(er).

-- 
GitHub Notification of comment by c1rrus
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/120#issuecomment-1331380509 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 29 November 2022 22:05:08 UTC