- From: Ryan Johnson via GitHub <sysbot+gh@w3.org>
- Date: Thu, 17 Nov 2022 22:41:45 +0000
- To: public-design-tokens-log@w3.org
I agree, there may be valid use cases for defining a `line-height` with a unit, so it makes sense that the `lineHeight` prop should support _either_ a unitless number or a Dimension. * The current drawback to Dimension support is that the spec only supports `px` units, but it's possible that it could be expanded in the future to support additional units. * Unfortunately, if an author requires the use of a `%` value, there's no token type in the spec that currently supports it. * A possible fallback for the `lineHeight` property _could_ be a verbatim string instead of a number or Dimension, but that runs the risk of incompatibility when translated to different environments. What works in CSS may not translate to other platforms. -- GitHub Notification of comment by CITguy Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/102#issuecomment-1319302665 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 17 November 2022 22:41:46 UTC