Re: [community-group] Typography type feedback (#102)

I, too want to point out that the current selection of properties seems very restrictive.

To make it more explicit these are a few I use regularly in our token system:
* `text-underline-offset` and `text-decoration-thickness`
* `word-spacing`
* `text-transform`

If they were missing from the spec I would definetly be unable to use the token format for our design tokens. I do think they are important, because they finally allow designer’s more control over the typography in digital designs.

My preferred solution would be to have an open spec (minimum requirements + user’s can add any property), with a list of spellings and definitions for common properties, that is not exhaustive but serves as a guide to tool-makers.

If the decision is made to make the spec closed and the list exhaustive, there are some properties that I’d consider out of scope because for me they are about the box that contains the type, rather than the type itself if that makes sense? E.g.:
* `hanging-punctuation`
* `hyphens`
* `text-align`

---

On another note, I think the description of the lineHeight property is somewhat ambiguous:

> - `lineHeight`: The vertical spacing between lines of typography. The value of this property must be a valid JSON string or a reference to a string token.

“The vertical spacing between lines of typography” doesn’t seem quite right to me. It sounds like it is describing [leading](https://en.wikipedia.org/wiki/Leading), as in the size of the lead strip put *between* two lines of text, when it is (probalby?) actually refering to the space from one baseline to the next (as in CSS and common design tools).

-- 
GitHub Notification of comment by ChristophLabacher
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/102#issuecomment-1050850074 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 25 February 2022 13:23:02 UTC